[FLINK-39902][tests] Fix race in RescaleTimelineITCase.testRescaleTerminatedByJobFinished#28378
Merged
RocMarshal merged 1 commit intoJun 13, 2026
Conversation
…minatedByJobFinished Unblocking the task raced with the scheduler recording the second rescale; on a slow machine the job finished first, leaving the history at size 1 and timing out the wait. Wait for the rescale to be recorded before unblocking. The assumeThat(enabledRescaleHistory) check had to move before the update RPC because the new size-2 history wait is only meaningful when rescale history is enabled; for the disabled parameter the history never grows and the wait would hang. Generated-by: Claude Opus 4.8 (1M context)
Collaborator
RocMarshal
approved these changes
Jun 13, 2026
RocMarshal
left a comment
RocMarshal
left a comment
Contributor
There was a problem hiding this comment.
Thanks @MartijnVisser
LGTM +1.
lihaosky
pushed a commit
that referenced
this pull request
Jun 13, 2026
…minatedByJobFinished (#28378) (#28413) Unblocking the task raced with the scheduler recording the second rescale; on a slow machine the job finished first, leaving the history at size 1 and timing out the wait. Wait for the rescale to be recorded before unblocking. The assumeThat(enabledRescaleHistory) check had to move before the update RPC because the new size-2 history wait is only meaningful when rescale history is enabled; for the disabled parameter the history never grows and the wait would hang. Generated-by: Claude Opus 4.8 (1M context) (cherry picked from commit ef4d88e) Co-authored-by: Martijn Visser <2989614+MartijnVisser@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
RescaleTimelineITCase.testRescaleTerminatedByJobFinishedis flaky on slow CI. The test requests an upscale to a parallelism that exceeds the available slots, so the rescale never changes the running parallelism and is only observable as a recorded history entry. It then unblocks the no-op task immediately, racing the scheduler recording that second rescale: on a slow machine the job finishes before the rescale is recorded, the history stays at size 1, and the size-2 wait times out.Brief change log
JOB_FINISHEDonce the job finishes.assumeThat(enabledRescaleHistory(...))skip ahead of the requirement update so the disabled-history variant skips cleanly.Verifying this change
Existing assertions are unchanged; the fix only enforces the ordering the sibling tests already get. Verified by running
testRescaleTerminatedByJobFinishedrepeatedly in a loop locally without failure.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.8 (1M context)